Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tx review: ability to tweak gas parameters #224

Open
naps62 opened this issue Jun 3, 2023 · 4 comments
Open

Tx review: ability to tweak gas parameters #224

naps62 opened this issue Jun 3, 2023 · 4 comments
Assignees
Labels

Comments

@naps62
Copy link
Member

naps62 commented Jun 3, 2023

No description provided.

@0xdorifto
Copy link
Contributor

Can I take this one?

@naps62
Copy link
Member Author

naps62 commented Sep 8, 2023

@0xdorifto you can, but I feel this one requires some planning (or some draft code so we can discuss how the UI will look without commiting too much time upfront)

this wasn't something I thought too much, and requires interaction between back-end and front-end (e.g.: to estimate whether the given gas values are good or not). but I guess we can start by drafting a first version of the UI, if that's ok with you

@0xdorifto
Copy link
Contributor

@naps62 sounds good to me.

@naps62
Copy link
Member Author

naps62 commented Sep 8, 2023

Some random thoughts that may help:

  • in terms of UI, this should allow tweaking the usual EIP1159 gas params
  • probably keep this in a collapsed section of the popup, so that it doesn't get in the way unless people do want to tweak them
  • when values are changed, the UI should trigger a simulation of the tx to display the usual feedback of whether the TX will succeed or not. this request doesn't need to be handled at first, but probably the UI should be built with that in mind

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants