Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix toWei(0.1,'wei') from returning 1 #3

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix toWei(0.1,'wei') from returning 1 #3

wants to merge 1 commit into from

Conversation

junderw
Copy link

@junderw junderw commented Dec 4, 2020

Fixes #1 and also adds tests for the 2 missing branches (unrelated to this PR) so now coverage is 100% across the board.

@junderw
Copy link
Author

junderw commented Dec 4, 2020

oof... looks like the dependencies I pulled in are newer than master, so a large diff was created in the pre-commit build...

I'll try to find the version being used here.

@junderw
Copy link
Author

junderw commented Dec 4, 2020

ok, nvm. all dependencies are specific versions...

Not quite sure how to deal with the built source... Should I maybe just remove them?

This was installed + built using the following node versions btw:

$ node -v
v12.18.3
$ npm -v
6.14.8

@junderw junderw mentioned this pull request Dec 4, 2020
Open
2 tasks
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling fc89e67 on junderw:fixToWei into 35d870e on ethjs:master.

@SilentCicero
Copy link
Member

Reviewing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

#toWei breaks for decimal inputs of "wei" and "noether"
3 participants
@junderw @coveralls @SilentCicero