TypedDataEncoder is badly encoding domain.chainId

[julien-devatom]

Ethers Version

6

Search Terms

TypedData Encoder domain signing message

Describe the Problem

inside of a JsonRpcProvider, when we call the signTypedData function, the domain.chainId is always formatted as a hex number, even if the number is a safe Integer

During the encoding process, this function is used to encode chainId. However, Number.isSafeInteger(BigInt) is always returning false. So the result is transformed by using toQuantity that is writing the chainId as an hexString.

As a consequence, some browser wallets such as wallet connect & frame wallet cannot decode the chain id correctly.

Code Snippet

You should do something like that:

if(Number.isSafeInteger(+(value.toString()))) return Number(value)

return toQuantity(value)

Contract ABI

No response

Errors

No response

Environment

node.js (older than v12), Browser (Chrome, Safari, etc)

Environment (Other)

No response