Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Travis CI break at head #212

Closed
bobsummerwill opened this issue Oct 7, 2019 · 3 comments
Closed

Travis CI break at head #212

bobsummerwill opened this issue Oct 7, 2019 · 3 comments
Assignees
Labels
bug action not working as intended/expected

Comments

@bobsummerwill
Copy link
Member

Thanks, @hi_chris.

I have just hit a CI issue which you might be more able to debug than me. Works fine in development, but hits build error in production:

https://travis-ci.org/ethereumclassic/ethereumclassic.github.io/builds/594379060?utm_source=github_status&utm_medium=notification

For this commit, where I added videos and slides for the first 8 ETC Summit sessions:

#211

Looks like it is a known issue, and we will need to do some JS workaround for it:

gatsbyjs/gatsby#16287

gatsbyjs/gatsby#309

@bobsummerwill bobsummerwill added the bug action not working as intended/expected label Oct 7, 2019
@IstoraMandiri
Copy link
Collaborator

IstoraMandiri commented Oct 15, 2019

It appears that the issue is related to permissions on the master branch rather than JS. I assume that this was enabled to prevent malicious updating (now requires 2 people to approve), which makes sense, but broke the Travis CI script.

I have updated the script so that Travis to push to a staging branch rather than master. A PR can be made from the staging branch for approval by moderators.

In future, once the script is complete, you'll need to create a PR from the staging branch into master and then it needs to be approved. For example, see #220, which needs to be approved.

Seems like this is a better flow as it means nobody can accidentally push a bad update unilaterally, and all updates are documented in PRs.

Other fixes:

  • Update CNAME to ethereumclassic.org
  • Removed some unused files in source

@bobsummerwill
Copy link
Member Author

Thanks - but the permissions issue was introduced AFTER the initial break, and is just hiding the JS break which will show up again when we get past this first one.

This is the break ...

https://travis-ci.org/ethereumclassic/ethereumclassic.github.io/builds/594379060?utm_source=github_status&utm_medium=notification

Please could you have a look at this, @hitchcott, and see if you can work out what we need to do in the JS to resolve this?

@bobsummerwill
Copy link
Member Author

Thanks for the review, @TheEnthusiasticAs.
I have merged now.
Still not convinced that we have addressed the underlying issue, but I guess we will find that out when I try to push my next set of view links through the process.

@realcodywburns realcodywburns added this to To do in Web Development via automation Nov 24, 2019
@realcodywburns realcodywburns moved this from To do to Done in Web Development Nov 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug action not working as intended/expected
Projects
No open projects
Development

No branches or pull requests

3 participants