You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
It appears that the issue is related to permissions on the master branch rather than JS. I assume that this was enabled to prevent malicious updating (now requires 2 people to approve), which makes sense, but broke the Travis CI script.
I have updated the script so that Travis to push to a staging branch rather than master. A PR can be made from the staging branch for approval by moderators.
In future, once the script is complete, you'll need to create a PR from the staging branch into master and then it needs to be approved. For example, see #220, which needs to be approved.
Seems like this is a better flow as it means nobody can accidentally push a bad update unilaterally, and all updates are documented in PRs.
Thanks - but the permissions issue was introduced AFTER the initial break, and is just hiding the JS break which will show up again when we get past this first one.
Thanks for the review, @TheEnthusiasticAs.
I have merged now.
Still not convinced that we have addressed the underlying issue, but I guess we will find that out when I try to push my next set of view links through the process.
Thanks, @hi_chris.
I have just hit a CI issue which you might be more able to debug than me. Works fine in development, but hits build error in production:
https://travis-ci.org/ethereumclassic/ethereumclassic.github.io/builds/594379060?utm_source=github_status&utm_medium=notification
For this commit, where I added videos and slides for the first 8 ETC Summit sessions:
#211
Looks like it is a known issue, and we will need to do some JS workaround for it:
gatsbyjs/gatsby#16287
gatsbyjs/gatsby#309
The text was updated successfully, but these errors were encountered: