Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check some of the older CI runs to see if there are flaky tests and ideally fix the flakiness #1359

Closed
Tracked by #1354
manuelwedler opened this issue Apr 18, 2024 · 1 comment
Assignees

Comments

@manuelwedler
Copy link
Collaborator

In the node-v16 CI job we have a few tests that are flaky, meaning that they sometimes pass and sometimes not. It would be nice to check which these tests are, and if possible make them deterministically passing or failing.

If there are tests that are expected to be flaky, since we cannot guarantee an external service to be up, then it makes sense to isolate these in their own CI job. That way we can distinguish more easily between an error on our side and a flaky test.
This issue should only be about identifying the flaky tests. For moving flaky tests to another CI job, we can create a follow up issue, once we are more clear on how we want to structure all of the tests.

@manuelwedler
Copy link
Collaborator Author

Closing as the tests are constantly successful for a while.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Sprint - Done
Development

No branches or pull requests

2 participants