Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shanghai Support #14073

Closed
9 of 12 tasks
ekpyron opened this issue Mar 27, 2023 · 5 comments
Closed
9 of 12 tasks

Shanghai Support #14073

ekpyron opened this issue Mar 27, 2023 · 5 comments
Assignees
Labels
high impact Changes are very prominent and affect users or the project in a major way. medium effort Default level of effort selected for development It's on our short-term development
Milestone

Comments

@ekpyron
Copy link
Member

ekpyron commented Mar 27, 2023

Tasks


References

@ekpyron ekpyron added selected for development It's on our short-term development medium effort Default level of effort high impact Changes are very prominent and affect users or the project in a major way. labels Mar 27, 2023
@ekpyron ekpyron added this to Triage in Solidity via automation Mar 27, 2023
@ekpyron ekpyron removed this from Triage in Solidity Mar 27, 2023
@github-actions github-actions bot added this to Triage in Solidity Mar 27, 2023
@ekpyron ekpyron removed this from Triage in Solidity Mar 27, 2023
@ekpyron ekpyron added this to the 0.8.20 milestone Apr 5, 2023
@ekpyron
Copy link
Member Author

ekpyron commented Apr 5, 2023

Adjust Yul optimizer to never CSE zeroes.

For the record: this part we can do in a subsequent step - as a matter of fact, as a first step plain support for the Opcode and generating it on a push with zero value in Assembly::assemble is enough for a first PR - the optimizer tweaking we can do later in a secondary step.

@ekpyron
Copy link
Member Author

ekpyron commented May 15, 2023

Changing the milestone to 0.8.21 for the remaining minor improvements in the optimizer.

@hrkrshnn
Copy link
Member

I also think we didn't implement this for --opcodes output yet. At least it doesn't seem to give me PUSH0. I'll check this.

@ekpyron
Copy link
Member Author

ekpyron commented May 15, 2023

I also think we didn't implement this for --opcodes output yet. At least it doesn't seem to give me PUSH0. I'll check this.

Should work implicitly (but better to confirm to be sure)

@NunoFilipeSantos
Copy link
Contributor

Shanghai support was released. The rest are optimizations we will eventually get to.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
high impact Changes are very prominent and affect users or the project in a major way. medium effort Default level of effort selected for development It's on our short-term development
Projects
Archived in project
Status: [ARCHIVED] ☀️ Q2 2023
Development

No branches or pull requests

4 participants
@ekpyron @NunoFilipeSantos @hrkrshnn and others