Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update deprecated github actions that the solc-bin PR check depends on #14059

Closed
cameel opened this issue Mar 20, 2023 · 1 comment · Fixed by ethereum/solc-bin#133
Closed

Update deprecated github actions that the solc-bin PR check depends on #14059

cameel opened this issue Mar 20, 2023 · 1 comment · Fixed by ethereum/solc-bin#133
Assignees
@r0qs
Labels
low effort There is not much implementation work to be done. The task is very easy or tiny. low impact Changes are not very noticeable or potential benefits are limited. refactor should have We like the idea but it’s not important enough to be a part of the roadmap. solcbin

Comments

@cameel
Copy link
Member

cameel commented Mar 20, 2023 •
edited

GitHub Actions: All Actions will begin running on Node16 instead of Node12

Our PR checks in solc-bin have been complaining about it for a while now. See e.g. run #135 on Fix nodejs version to 16 in nightly builds:

generate (emscripten-wasm32, ubuntu-latest)
Node.js 12 actions are deprecated. Please update the following actions to use Node.js 16: actions/setup-python@v2, actions/checkout@v2, actions/upload-artifact@v2. For more information see: https://github.blog/changelog/2022-09-22-github-actions-all-actions-will-begin-running-on-node16-instead-of-node12/.

We're not explicitly using node 12 (in fact we update it to node 16) so I think this must be caused by the stock actions that we invoke. They're even listed in the message:

  • actions/setup-python@v2
  • actions/checkout@v2
  • actions/upload-artifact@v2

Just switching to a newer version for each of them should do the trick.
@cameel cameel added solcbin low effort There is not much implementation work to be done. The task is very easy or tiny. low impact Changes are not very noticeable or potential benefits are limited. should have We like the idea but it’s not important enough to be a part of the roadmap. refactor labels Mar 20, 2023
@cameel cameel added this to Triage in Solidity via automation Mar 20, 2023
@cameel cameel removed this from Triage in Solidity Mar 20, 2023
@github-actions github-actions bot added this to Triage in Solidity Mar 20, 2023
@cameel cameel removed this from Triage in Solidity Mar 20, 2023
@BraxWong
Copy link
Contributor

I can take this if nobody wants to

BraxWong added a commit to BraxWong/solc-bin that referenced this issue Apr 26, 2023
@BraxWong
Fixed deprecated github actions that the solc-bin PR check #14159
759a109 
Fixes ethereum/solidity#14059
Have changed from actions/checkout@v2 actions/setup-python, actions/upload-artifact, and actions/download-artifact to v3 which should eliminate the warning message. Changes are made in nightly-emscripten and t-bytecode-compare.yml file
@BraxWong BraxWong mentioned this issue Apr 26, 2023
Closed
@r0qs r0qs mentioned this issue May 10, 2023
Merged
@github-actions github-actions bot added the stale The issue/PR was marked as stale because it has been open for too long. label Jul 26, 2023
@ekpyron ekpyron removed the stale The issue/PR was marked as stale because it has been open for too long. label Jul 26, 2023
@ethereum ethereum deleted a comment from github-actions bot Jul 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@r0qs r0qs

Labels
low effort There is not much implementation work to be done. The task is very easy or tiny. low impact Changes are not very noticeable or potential benefits are limited. refactor should have We like the idea but it’s not important enough to be a part of the roadmap. solcbin
Projects
Solidity Focus Board
Archived in project
Milestone
No milestone
4 participants
@cameel @r0qs @ekpyron @BraxWong