Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch to Gen2 macOS resources on CircleCI #14058

Closed
cameel opened this issue Mar 20, 2023 · 1 comment · Fixed by #14164
Closed

Switch to Gen2 macOS resources on CircleCI #14058

cameel opened this issue Mar 20, 2023 · 1 comment · Fixed by #14164
Assignees
@r0qs
Labels
build system 🏗️ low effort There is not much implementation work to be done. The task is very easy or tiny. low impact Changes are not very noticeable or potential benefits are limited. refactor should have We like the idea but it’s not important enough to be a part of the roadmap.

Comments

@cameel
Copy link
Member

cameel commented Mar 20, 2023

CircleCI is deprecating large and medium resource classes for macOS: macOS Resource Deprecation Update. We're using those so we should switch to the new ones and make sure everything works.

Hopefully, should be as simple as changing their names in our config.
@cameel cameel added build system 🏗️ low effort There is not much implementation work to be done. The task is very easy or tiny. low impact Changes are not very noticeable or potential benefits are limited. must have Something we consider an essential part of Solidity 1.0. refactor labels Mar 20, 2023
@cameel cameel added this to Triage in Solidity via automation Mar 20, 2023
@cameel cameel removed this from Triage in Solidity Mar 20, 2023
@github-actions github-actions bot added this to Triage in Solidity Mar 20, 2023
@cameel cameel added should have We like the idea but it’s not important enough to be a part of the roadmap. and removed must have Something we consider an essential part of Solidity 1.0. labels Mar 20, 2023
@BraxWong
Copy link
Contributor

I can take this

BraxWong added a commit to BraxWong/solidity that referenced this issue Apr 26, 2023
@BraxWong
Switch to Gen2 macOS resources on CircleCI
b4ea5ee 
Fixes: ethereum#14058
Medium resource class tags have been replaced with macos.x86.medium.gen2 and large resource class tags have been replaced with macos.m1.large.gen1. I believe the updated Gen2 resource is available with the free plan. and the new large resource is coming in at 400 credits per minute
@BraxWong BraxWong mentioned this issue Apr 26, 2023
Closed
BraxWong added a commit to BraxWong/solidity that referenced this issue Apr 27, 2023
@BraxWong
Setting the resource_class for base_osx to the new medium tag. Revert…
c16430e 
…ing all resource_class tag back to large except for base_osx_large

Switch to Gen2 macOS resources on CircleCI

Fixes: ethereum#14058
Medium resource class tags have been replaced with macos.x86.medium.gen2 and large resource class tags have been replaced with macos.m1.large.gen1. I believe the updated Gen2 resource is available with the free plan. and the new large resource is coming in at 400 credits per minute

Revert previous changes and keeping only base_osx_large with the updated resource class tag
BraxWong added a commit to BraxWong/solidity that referenced this issue Apr 27, 2023
@BraxWong
Switch to Gen2 macOS resources on CircleCI
7079a55 
Fixes: ethereum#14058 base_osx now has the macos.x86.medium.gen2 tag and base_osx_large has the macos.m1.large.gen1 tag. I believe the updated Gen2 resource is available with the free plan. and the new large resource is coming in at 400 credits per minute
@BraxWong BraxWong mentioned this issue Apr 27, 2023
Merged
@cameel cameel removed this from Triage in Solidity Apr 27, 2023
BraxWong added a commit to BraxWong/solidity that referenced this issue May 3, 2023
@BraxWong
Switch to Gen2 macOS resources on CircleCI
9428e9a 
Fixes: ethereum#14058 base_osx now has the macos.x86.medium.gen2 tag and base_osx_large has the macos.m1.large.gen1 tag. I believe the updated Gen2 resource is available with the free plan. and the new large resource is coming in at 400 credits per minute
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@r0qs r0qs

Labels
build system 🏗️ low effort There is not much implementation work to be done. The task is very easy or tiny. low impact Changes are not very noticeable or potential benefits are limited. refactor should have We like the idea but it’s not important enough to be a part of the roadmap.
Projects
Solidity Focus Board
Archived in project
Milestone
No milestone
3 participants
@cameel @r0qs @BraxWong