Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jsontestsuite failed to execute in Windows #1277

Open
oracle3 opened this issue Apr 28, 2019 · 2 comments
Open

Jsontestsuite failed to execute in Windows #1277

oracle3 opened this issue Apr 28, 2019 · 2 comments

Comments

@oracle3
Copy link

oracle3 commented Apr 28, 2019

in function
org.ethereum.jsontestsuite.suite.JSONReader.listJsonBlobsForTreeSha(String, String)
old code:

                    jsons.add(
                            f.replace(path + System.getProperty("file.separator"), "")
                             .replaceAll(System.getProperty("file.separator"), "/"));

should change to:

                    jsons.add(
                            f.replace(path + System.getProperty("file.separator"), "")
                             .replaceAll(Matcher.quoteReplacement(System.getProperty("file.separator")), "/"));
@mkalinin
Copy link
Contributor

Hm, got your point. Would you mind creating a PR with this change?

@oracle3
Copy link
Author

oracle3 commented Apr 30, 2019

how to creating a PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants