Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No verifies the signature against the Transacton? #1223

Open
quan420 opened this issue Oct 31, 2018 · 1 comment
Open

No verifies the signature against the Transacton? #1223

quan420 opened this issue Oct 31, 2018 · 1 comment
Labels
Projects

Comments

@quan420
Copy link

quan420 commented Oct 31, 2018

I can't find any Verifies the ECDSA signature against the Transacton in ethereumj.
Should ECKey.verify be call in Transaction.validate or some other flows?

And in go-ethereum there are ecdsa signature validate of the transaction :
func (pool *TxPool) validateTx(tx *types.Transaction) (e error) {

from, err := types.Sender(pool.signer, tx)
if err != nil {
	e = ErrInvalidSender
	return
}
@mkalinin mkalinin added this to Backlog in Core via automation Nov 7, 2018
@mkalinin
Copy link
Contributor

mkalinin commented Nov 7, 2018

Isn't it a check that you're looking for?

if (!blockchainConfig.acceptTransactionSignature(tx)) {
execError("Transaction signature not accepted: " + tx.getSignature());
return;
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Core
  
Backlog
Development

No branches or pull requests

2 participants