Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warn/fail if a proposal is created in Review (or later) status #351

Open
SamWilsn opened this issue Nov 16, 2023 · 3 comments
Open

Warn/fail if a proposal is created in Review (or later) status #351

SamWilsn opened this issue Nov 16, 2023 · 3 comments

Comments

@SamWilsn
Copy link
Contributor

SamWilsn commented Nov 16, 2023

Downstream tooling requires each proposal be merged as a Draft first, then move to Review. If the proposal appears first in Review, it messes up statistics.

Originally reported by @poojaranjan on discord.

@Pandapip1
Copy link
Member

eip-review-bot currently flags any such proposals as e-consensus and requires half of all editors (rounded down) to approve. Would you prefer alternative behavior?

@poojaranjan
Copy link

I suppose, we can use a message for the author/reviewer with the "reason for the flag" will be helpful.

Something like "No Draft available in EIPs/ERCs repository" for a PR requesting to be added as a Review instead of Draft. It will help authors & reviewers of PRs like this and it could be merged with an appropriate status.

If possible, this check should be made available for all statuses. As similar issue of missing a status (Review) was also noticed here with a Meta EIP.

@Pandapip1
Copy link
Member

Pandapip1 commented Nov 17, 2023

That last one is odd and shouldn't have happened. More helpful messages are definitely something that would be useful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants