Cannot delete files

[Pandapip1]

Deleting files in the assets folder anywhere causes EIP-bot to throw with a "not found" message, resulting in the PR failing to merge.

[JEAlfonsoP]

Any particular reason why has been this "reopened" ?

[Pandapip1]

The fix apparently didn't work.

[JEAlfonsoP]

That fix as you mentioned, was addressed in EIPW ? (Question)

[Pandapip1]

No, it wasn't.

[JEAlfonsoP]

Deleting EIP asset file == modifying EIP asset files ? (Question), if this is the case then it would be covered with Issue
#95.

[Pandapip1]

No, this is different. If any file is deleted, EIP-bot throws

[JEAlfonsoP]

is anyone working on it ?

[Pandapip1]

No, there is not.

[JEAlfonsoP]

I will take a look on it.

[SamWilsn]

I'm not looking at this one.

[JEAlfonsoP]

Hi.
I did several tests and PRs in the testing environment for this.

1. There is no bug with any of the bots: EIP-Bot and EIPW.
   The test: https://github.com/JEAlfonsoP/EIPs/actions/runs/3093930099/jobs/5006818557
   EIPW fails because the file pretending to be merged into the EIP repo does not follow EIP-1 rules. e.g:
   Error: error: first line must be --- exactly
   --> EIPS/eip-5255.md
   |
   1 | Delete EIP-5000
   |

This is the first line for: ethereum/EIPs@bdaf424

2. Try to merge and delete an EIP: (Please I just try to delete last EIP-merged)
   Delete eip-5679.md JEAlfonsoP/EIPs#16
   Actions: https://github.com/JEAlfonsoP/EIPs/actions/runs/3098269137 (No failure for any BOT).
   There is a failure from CI: https://github.com/JEAlfonsoP/EIPs/actions/runs/3098269137/jobs/5015970668 (CodeSpell due to the fact that this empty case is not considered).

Sam, may be the messages from EIPW could be a more explicative (a suggestion).
PandaPip1, I presume that this empty check might be included in CI.
General Observation: Any file to be merged must follows EIP1 rules.

Beside this I think that the case for deleting any file from the EIPs repo is solved.

Let me know if you need something else or if it's Ok so this issue could be closed.

[Pandapip1]

Your particular test didn't work because of an API rate limit: https://github.com/JEAlfonsoP/EIPs/actions/runs/3098245342/jobs/5015914203

[JEAlfonsoP]

Your particular test didn't work because of an API rate limit: https://github.com/JEAlfonsoP/EIPs/actions/runs/3098245342/jobs/5015914203

? What is this Panda ?
I do not understand it. I do not find that error during testing.

But I see from your test that:
'x-ratelimit-used': '60',
is working.

[Pandapip1]

I am stating, as a fact, that deleting any file incorrectly throws a "not found" error due to the github API (correctly) giving a 404 error when the "updated" file is fetched. This is a bug, and is separate from any other CI elements correctly failing.

[JEAlfonsoP]

You need to consider the fact that deleting an EIP's repo file does not activate EIP-Bot. Solving #95 should fixes what you said.
However CI elements failing we agreed.

As I mentioned two weeks ago, If you or Sam are working in any other Bot to fix this issue or 95 please re-reconfirm so I do not test, code and PR any of it as I just did for this one.

[Pandapip1]

You need to consider the fact that deleting an EIP's repo file does not activate EIP-Bot.

Yes, it does.

[JEAlfonsoP]

You need to consider the fact that deleting an EIP's repo file does not activate EIP-Bot.

Yes, it does.

Interesting. If you have a test case with the actual ./workflow please share it if you like, so I can take a look on it.
Regardless, please, I ask you again that you advice if:
a.- You are working on this issue or any other one from this repo. So I avoid time consumption on it.

Thank you !