Skip to content
This repository has been archived by the owner on Oct 18, 2022. It is now read-only.

Fix deployedBytecode to perform Find and replace #21

Open
K-Ho opened this issue Apr 9, 2021 · 3 comments
Open

Fix deployedBytecode to perform Find and replace #21

K-Ho opened this issue Apr 9, 2021 · 3 comments

Comments

@K-Ho
Copy link
Contributor

K-Ho commented Apr 9, 2021

No description provided.

@ben-chain
Copy link
Contributor

basically we need to either:

  1. replicate this logic for deployedbytecode, but get it to work
  2. upgrade to a version of solidity where we don't have to do the hack in the first place, so that the kall builtin actually can be accepted as a literal value. This PR is gonna do the trick, but it might come with it an entire compiler rewrite using yul IR!

@K-Ho
Copy link
Contributor Author

K-Ho commented May 14, 2021

Bump on this - this becomes an issue for anyone who wishes to use deployedBytecode to verify and publish on etherscan (cc @ajsantander)

@Enigmatic331
Copy link

Will be keeping an eye on this 😄 - I guess the issue is mostly present in 0.5.16 as I had luck with 0.7.6.

Haven't tried 0.6.12 and 0.8.4 yet (maybe I should)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants