Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

op-node: Increase MaxFrameLength + Check buffer size against FrameLength #10470

Open
trianglesphere opened this issue May 9, 2024 · 0 comments
Open

op-node: Increase MaxFrameLength + Check buffer size against FrameLength #10470

trianglesphere opened this issue May 9, 2024 · 0 comments

Comments

@trianglesphere
Copy link
Contributor

Several Changes

  1. MaxFrameLen should be increased to 10MB from 1MB
  2. Inside func (f *Frame) UnmarshalBinary(r ByteReader) error we should validate frameLength against the remaining bytes
  3. We need to update the specs + make MaxFrameLen a clear protocol constant.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@trianglesphere