Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API v2 #1889

Open
ligi opened this issue Nov 18, 2022 · 6 comments
Open

API v2 #1889

ligi opened this issue Nov 18, 2022 · 6 comments
Labels
enhancement New feature or request

Comments

@ligi
Copy link
Member

ligi commented Nov 18, 2022

API v2 should change faucets (#1884) and RPC (some ideas here #1829 (comment))
old data format should be kept for a while (as output) - new one added at /v2 - fallback should be possible with these both changes

@ethereum-lists ethereum-lists deleted a comment from ullashb Nov 19, 2022
@ethereum-lists ethereum-lists deleted a comment from ullashb Nov 19, 2022
@ligi ligi added the enhancement New feature or request label Nov 19, 2022
@kopeboy
Copy link

kopeboy commented Mar 7, 2023

I would add a "isTestnet" boolean, useful to all indexers/trackers/DEXes/etc.
My suggested definition of "true" when the entity adding the chain definiton to the list doesn't specify it, would be having centralized minting of the native/fee token, ie. the token not having consensus economic value.

@ligi
Copy link
Member Author

ligi commented Mar 7, 2023

My reasoning for not wanting isTestNet: #2351

@kopeboy
Copy link

kopeboy commented Apr 17, 2023

your reasoning is "Goerli has now value, people test on Mainnet"..
I said it depends on the minting process of the native token being decentralized.

@ligi
Copy link
Member Author

ligi commented Apr 17, 2023

The lines are really blurry. I really do not think a boolean flag makes sense here.

@kopeboy
Copy link

kopeboy commented Apr 17, 2023 via email

@ligi
Copy link
Member Author

ligi commented Apr 17, 2023

but in the end I need to review the PR - not sure how I can meaningfully do this for that value as I think it is not boolean.
Just check if there is a faucet - IMHO this is a good indicator if this is a testnet.
Also why wouldn't you allow testnet chains to be connected to your "production" service? IMHO this is great for .. testing ..-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants
@ligi @kopeboy and others