Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add GasPrice information #162

Open
ligi opened this issue Feb 16, 2021 · 2 comments
Open

Add GasPrice information #162

ligi opened this issue Feb 16, 2021 · 2 comments
Labels
enhancement New feature or request

Comments

@ligi
Copy link
Member

ligi commented Feb 16, 2021 •
edited

this is a follow-up and replaces #24

we should add a field "gasPrice" like this:

{
"infoURL": "https://gasnow.org",
"eips": [ "1599" ],
"defaultValue": "2000000000" 
}

Still thinking about a field that indicates if a gas price is stable "Under ordinary circumstances," like in xDAI
https://challenge.xdaichain.com/cost-estimates
@ligi ligi added the enhancement New feature or request label Feb 16, 2021
ligi added a commit to walleth/walleth that referenced this issue Feb 16, 2021
@ligi
Do not save the GasPrice for Rinkeby, Goerli and xDAI
951e756 
Also set default to 1GWEI
In the future get info from ethereum-lists/chains

ethereum-lists/chains#162
ligi added a commit to walleth/walleth that referenced this issue Feb 24, 2021
@ligi
Do not save the GasPrice for Rinkeby, Goerli and xDAI
154f6bf 
Also set default to 1GWEI
In the future get info from ethereum-lists/chains

ethereum-lists/chains#162
ligi added a commit to walleth/walleth that referenced this issue Feb 24, 2021
@ligi
Do not save the GasPrice for Rinkeby, Goerli and xDAI
5b2ea1f 
Also set default to 1GWEI
In the future get info from ethereum-lists/chains

ethereum-lists/chains#162
ligi added a commit to walleth/walleth that referenced this issue Feb 24, 2021
@ligi
Do not save the GasPrice for Rinkeby, Goerli and xDAI
ee44168 
Also set default to 1GWEI
In the future get info from ethereum-lists/chains

ethereum-lists/chains#162
@ligi
Copy link
Member Author

ligi commented Mar 6, 2021

thinking about it more - I think the eip's should have a starting block

@ligi
Copy link
Member Author

ligi commented Apr 12, 2021

also I think the EIPs should be lifted out of the GasInfo block

jewel528 added a commit to jewel528/walleth that referenced this issue Feb 16, 2024
@jewel528
Do not save the GasPrice for Rinkeby, Goerli and xDAI
a0f8a02 
Also set default to 1GWEI
In the future get info from ethereum-lists/chains

ethereum-lists/chains#162
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ligi