-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Uncaught TypeError: Cannot read property 'setStateIdle' of null #3405
Comments
Related? |
Indeed it is, @caugner. @anugu-chegg, since you worked closely on this file for #3318, do you have some hints? |
Hey, I can no longer reproduce the issue with a proper proxy setup: https://github.com/ether/etherpad-lite/wiki/How-to-put-Etherpad-Lite-behind-a-reverse-Proxy So i guess the issue is really down to the socket connection and reading all the guides may help? 😂 |
Good news, @fralix. I leave the issue open, since I continue being curious about the "phantom" initialization uncovered by @caugner. I am starting to think about how to improve the codebase without rewriting it (more tests, linters, static analyzers, maybe even gradually migrating to TypeScript...), and this sort of issues interest me a lot. |
Hi there,
We have this plugins installed:
Just wanted to report it! |
I can confirm that this error is also present in v1.8.0.
|
I am using etherpad_lite version 1.6.0 version. we have also observed this issue like that
Any one can find out the solution for this issue ? and I know that issue related to socket connection but not find out the exact root cause for this issue why getting socket on error ? |
@vijaygodhasara Please don't use Etherpad 1.6. Please update and let us know if it persists. |
@xshadow Please provide some information such as:
|
FWIW I am not seeing this bug at all across any of our instances so I think it's a configuration issue or something that isn't related to Core. |
Please look at #3405 (comment) - After a successful proxy setup this issue disappeared for me. I saw it again when there was an unstable network connection, so it's probably down to some issues with something not correctly accessible, but mainly a setup / network issue. I think this bug can be closed when current reporters don't reply and if someone experiences it again, they should provide more details about the configuration and check if it's a problem with their network connection ... Also, it's very helpful to open the browser debug console and check for network connections. Especially some wrongly setup CSPs can prevent resources from loading. I just had this with another project. |
Closing, will re-open if someone experiences moving forward. |
If someone experiences problems while setting up an instance (when there is no sensitive user data) it might be interesting to have a look at the system and start debugging from there. I guess I could afford the time to check if it's a general issue with the system configuration, but I'm no NodeJS / etherpad developer, so I won't be able to continue debugging if it appears to be indeed an etherpad bug. |
@JohnMcLear After a review of the Proxy settings I can confirm that fix mentioned in the comments above did the trick. |
This error is reproduced on different instances of the etherpads in the android and chrome.
Steps to reproduce
|
Oh.. Android... Sec. |
Confirmed error! Well done for replicating. You get a cookie good sir! :) |
Cannot replicate locally on latest develop. So this is fun :) Can replicate on video.etherpad.com:9001 (which afaik is direct to Etherpad). So to narrow it down it's possibly related to:
Firefox (the good browser) errors with What are mobile browsers doing different to normal browsers? |
It appears it's fixed in latest develop already.. I pulled latest onto https://video.etherpad.com Can you still replicate? Etherpad moves quite quick so it's possible this was an edge case in the version prior to me pulling. video.etherpad.com often is a few weeks behind develop because I'm too busy to keep her updated ;/
|
Hi @JohnMcLear! Congratulations, the error cannot be reproduced on https://video.etherpad.com. |
It's still there. I can replicate after looking at the code, but I am not sure how this is connected to closing&reopening the tab in android. In pad.js' handshake function, callbacks for socket events are registered that use collabClient. However, collabClient is null until it is set in _afterHandshake right after CLIENT_VARS are received. |
So the next question is why did updating and restarting video.etherpad.com fix??! |
A bisect showed 128f3e1 as the fix-commit. That kind of makes sense. |
Next level pro developer fixes bugs before they manifest.... |
I think there was some issue in jquery or the way we use it, that was easily triggerable and is now resolved with 128f3e1 |
I'm using 1.8.6 and I still got the error! |
@cdruet can you provide any details? Did you test without plugins? |
@JohnMcLear I have the same problem with 1.8.6 (master branch) Here is an example: https://mrtopf.de/test.html loading this pad: https://yopad.eu/p/textframe Installed plugins are comments_page and headings2. I hopefully have time later to test it on fresh install without plugins (as I don't necessarily want to disable them on production) |
@JohnMcLear I'm also using comments_page. On top of that auth_session.
I can test later today without comments_page but I'm auth_session to reach the pads.
Sent with Unibox
|
@cdruet and @mrtopf: Can you try the latest commit on the |
@rhansen can this be closed now? |
@rhansen sorry, was a bit busy and setting up a test server took a bit. But I tested |
I got this error with 1.8.5 & the current master version (based on 1.8.6 = commit 2c8769a) when updating to develop, the first tests seems to be fine. when is the next release expected? Setting: include etherpad via iframe in a server running on localhost. Stack trace (from the master version, 1.8.6++ as mentioned above), in case this is still relevant:
|
Soon. Hopefully this week. |
I'm getting the following error in Chrome 66 when accessing a pad in our instance (running 1.6.6).
Meanwhile, access with Firefox 60 works without problems. Any tips?
It seems to stem from this code section, where
pad.collabClient
seems to be null:When pausing with a breakpoint, the error
e
is undefined.According to the call stack, the error occurred in this call:
P.S.: It's actually suprising that
pad.collabClient
is already used in thehandshake()
, while it is only initialized in_afterHandshake()
.P.P.S.: Troubleshooting information as follows:
The text was updated successfully, but these errors were encountered: