Authorship of bullet points changes when a second author edits them #3354
Comments
|
I'm pretty sure this is a duplicate no? |
|
@JohnMcLear I have just re-read the list of open issues and I cant find anything that makes me think this is a duplicate issue. I also looked more closely at the results for searching for "color" and "author" with no luck finding a dup. |
|
@lpagliari, this is frustrating many of my colleagues. Do you have any updates? |
|
sorry, guys, I didn't have time to focus on Etherpad lately. I'll try to take a look on the next few days |
|
I could reproduce the first issue (line author is fully changed), but not the second one (author name shows as "[ojbect object]"). I'm still investigating the causes... |
|
Hi @lpagliari, Have you had a chance to look at the line author issue? We could really use a fix for this even if you haven't had a chance to look at the second issue. |
|
@dgoldfein yes, I've been investigating the issue for the past couple of weekends. I still don't have a fix for it, but at least I found the commit that broke the behaviour. I'm looking on how to fix that now. |
When comparing original content with the changes made by the user, we need to ignore some line attribs that are added by content collector, otherwise we would consider the change started on the first char of the line -- the '*' that is added when line has line attribs. In order to be able to handle both #3354 and #3118, we need to take into account both the styles attribs (to fix #3354) and the line attribs defined by any of the plugins (to fix #3118), but we can ignore those extra line attribs that are added by Etherpad and do not add any functionality (`'lmkr', 'insertorder', 'start'`).
When comparing original content with the changes made by the user, we need to ignore some line attribs that are added by content collector, otherwise we would consider the change started on the first char of the line -- the '*' that is added when line has line attribs. In order to be able to handle both #3354 and #3118, we need to take into account both the styles attribs (to fix #3354) and the line attribs defined by any of the plugins (to fix #3118), but we can ignore those extra line attribs that are added by Etherpad and do not add any functionality (`'lmkr', 'insertorder', 'start'`).
…3420) When comparing original content with the changes made by the user, we need to ignore some line attribs that are added by content collector, otherwise we would consider the change started on the first char of the line -- the '*' that is added when line has line attribs. In order to be able to handle both #3354 and #3118, we need to take into account both the styles attribs (to fix #3354) and the line attribs defined by any of the plugins (to fix #3118), but we can ignore those extra line attribs that are added by Etherpad and do not add any functionality (`'lmkr', 'insertorder', 'start'`).
|
Ok, after a (long) while, I was able to find a way to handle all the scenarios, and this issue is finally fixed. |
|
@lpagliari, Thanks for fixing this! We tested the dev code in our test environment and the fixes worked. Can't wait for the next official release! |
|
@lpagliari Any change of getting this rolled into an official release? Who should I contact about that? |
|
My main concern is #3268: it fixes a bug, but breaks plugins. If I had to cut a release right now, I would:
|
This has been recreated in both in our internal version of etherpad and on beta.etherpad.org (https://beta.etherpad.org/p/tapril_test).
When one author adds content to a bulleted list of items, the authorship correctly indicates the author. Once a second author modifies the bullet point, the authorship of the full bullet point changes to the second author and when using the hover author plugin, the author name shows as "[ojbect object]".
I do not recall this being an issue on 1.5.1 or before but I have not had a chance to go and do a binary search on the versions to figure out where the bug was introduced.
The text was updated successfully, but these errors were encountered: