Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The use of .scss format #67

Open
ethantw opened this issue Jan 8, 2015 · 2 comments
Open

The use of .scss format #67

ethantw opened this issue Jan 8, 2015 · 2 comments
Labels

Comments

@ethantw
Copy link
Owner

ethantw commented Jan 8, 2015

Han.css is developed using .sass format in most cases for its conciseness. From v3.1.0, where we started using Gulp for development, the main files (src/sass/han.scss and index.scss) switched to .scss format since the module gulp-sass fails to compile .sass files correctly. Will switch back once the bug is fixed.

@ethantw ethantw added the bug label Jan 8, 2015
@ys-chung
Copy link

Doesn't writing Han.css in SCSS better than writing it in SASS? Because SCSS is closer to CSS, doesn't this make new contributors unfamiliar with SASS or SCSS easier to contribute?

@ethantw
Copy link
Owner Author

ethantw commented Aug 10, 2015

My opinion is that there are hundreds of languages using indentation instead of curly brackets to delimit ranges. I don’t see why we shouldn’t use the Sass format. It is cleaner to look at and easier to write. That’s just a matter of preference. 😄

FYI, the SCSS format is used in some cases in the project, such as listing font-family. https://github.com/ethantw/Han/blob/master/src/sass/typography/ff/_biaodian.scss

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants