Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fast NPC animations sometimes jump around #316

Open
ethanmoffat opened this issue May 22, 2023 · 0 comments
Open

Fast NPC animations sometimes jump around #316

ethanmoffat opened this issue May 22, 2023 · 0 comments
Labels
Milestone

Comments

@ethanmoffat
Copy link
Owner

NPC animation timing sometimes causes NPCs to jump around when walking quickly. This is because the time between packets for the fastest NPCs is sometimes quicker than the time it takes for all frames of an NPC animation to complete, and NPCAnimator will skip that walk/attack if one is already in progress.

Instead, NPCs should use a similar strategy as characters by taking advantage of the "Replay" functionality of RenderFrameActionTime. Instead of discarding an incoming animation if another is already in progress, Replay can be set to true, which looks closer to what the vanilla client does.

@ethanmoffat ethanmoffat added this to the Version 1 milestone May 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant