Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

don't can implement skeletonScreen.hide() #46

Open
Fuadafdhal opened this issue Jun 17, 2020 · 3 comments
Open

don't can implement skeletonScreen.hide() #46

Fuadafdhal opened this issue Jun 17, 2020 · 3 comments

Comments

@Fuadafdhal
Copy link

i don't can't can implement skeletonScreen.hide()

@Fuadafdhal
Copy link
Author

how to hide the skeletonScreen

@H43RO
Copy link

H43RO commented Aug 22, 2020

Skeleton.bind()... returns 'Skeleton' Object.
You should to hide the skeleton Screen with this object

val skeleton = Skeleton.bind(recyclerView).adapter(viewAdapter).show()
skeleton.hide() // on Date Binding Completed

@OctoberCat
Copy link

OctoberCat commented Oct 27, 2020

Funny thing, actually you should use return object of show() method: RecyclerViewSkeletonScreen
As example:

 //fun onViewCreated
   val skeleton = loadAnimation.show()
        compositeDisposable.add(
            viewModel.reportsSubject.subscribe { reports ->
                reportsAdapter.update(reports)
                skeleton.hide()
            }

IMHO this is a bad decission in library design.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants