Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Memory Tagging #44

Open
ritzdorf opened this issue Nov 19, 2018 · 0 comments
Open

Improve Memory Tagging #44

ritzdorf opened this issue Nov 19, 2018 · 0 comments
Labels
Bug Something isn't working
Milestone

Comments

@ritzdorf
Copy link
Collaborator

ritzdorf commented Nov 19, 2018

Memory tagging needs to be improved for certain opcodes including ReturnDataCopy and CallDataCopy.

Reference:
https://github.com/eth-sri/securify/blob/master/src/main/java/ch/securify/analysis/AbstractDataflow.java#L472

Example:

No MissingInputValidation here:

contract SimpleBank {
    bytes32 x;
    function withdraw(bytes  memory a) public {
        x = keccak256(a);
    }
}

but it is detected if a non-dynamic data type is used.

@ritzdorf ritzdorf added the Bug Something isn't working label Nov 19, 2018
@MatthiasEgli-chainsecurity MatthiasEgli-chainsecurity added this to the Sprint #2 milestone Nov 20, 2018
@hiqua hiqua removed their assignment Mar 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants