Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spack package #96

Open
haampie opened this issue Aug 31, 2021 · 2 comments
Open

Spack package #96

haampie opened this issue Aug 31, 2021 · 2 comments

Comments

@haampie
Copy link

haampie commented Aug 31, 2021

Hi,

I'm trying to make this package spack installable, see spack/spack#25713. While doing so, I wonder why:

  1. sklearn is in requirements.txt, isn't that deprecated long ago?
  2. sphinx, sphinx_rtd_theme and coverage are listed in requirements.txt, these are development dependencies? Can they be moved to a separate dev-requirements.txt or something?
  3. there aren't really lower and upper bounds for dependencies in requirements.txt, what if dependencies make breaking changes?

Thanks!

@statrita2004
Copy link
Collaborator

Thanks Herman. Let me look into this issue and will update the requirements soon. Will get back to you.

@haampie
Copy link
Author

haampie commented Sep 21, 2021

FWIW spack/spack#25713 is merged now.

It'd be great if the non-essential dependencies could be dropped in a future release! And if someone could verify that the Spack package actually works / tests pass, that'd be great

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants