Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Self-copy check for MatrixRef needs to be more thorough #1035

Open
msimberg opened this issue Nov 15, 2023 · 0 comments
Open

Self-copy check for MatrixRef needs to be more thorough #1035

msimberg opened this issue Nov 15, 2023 · 0 comments
Assignees
@msimberg
Labels
Priority:High TODO:Task
Milestone
API refactoring

Comments

@msimberg
Copy link
Collaborator

#1021 (comment). It currently checks for equality of addresses of the two MatrixRefs passed to copy. However, this misses at least the case where two different MatrixRefs point to the same underlying Matrix.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@msimberg msimberg

Labels
Priority:High TODO:Task
Projects
DLA-F Planning
Status: In Progress
Milestone
API refactoring
Development

No branches or pull requests
1 participant
@msimberg