You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The pfunc call in the GetDotPlot function in FullFold.cpp has teh complexity hardcoded to 3, sodium hardcoded to 1, magnesium hardcoded to 0, and use_long_salt hardcoded to 0. The big issue is complexity 3 being hardcoded as to find pairs for pknots you need to pass complexity as 5 or 8. A complexity of 3 is for non-pknot structures. The pfunc code uses complexity to determine whether to perform pknot routines and a complexity 3 means only run simple non-pknot routines. It is worth noting that we do set the global C variable for sodium, magnesium and long salt, and complexity adn they are the same but the complexity is a big issue
The text was updated successfully, but these errors were encountered:
LunarFawn
changed the title
GetDotPlot in FullFold.cpp is hardcoded with numerical values that should have variables which are defined at call
GetDotPlot in FullFold.cpp is hardcoded with numerical values that prevent pseudoknots pairs from ever being returns
Aug 14, 2022
LunarFawn
changed the title
GetDotPlot in FullFold.cpp is hardcoded with numerical values that prevent pseudoknots pairs from ever being returns
GetDotPlot in FullFold.cpp is hardcoded with numerical values that prevent pseudoknots pairs from being returned properly
Aug 14, 2022
luxaritas
changed the title
GetDotPlot in FullFold.cpp is hardcoded with numerical values that prevent pseudoknots pairs from being returned properly
Dot plot is not evaluated with pknots when pknots are enabled
Mar 22, 2023
While I will mark this as a bug, we have intentionally not fixed this due to the long compute time when enabling pknots for the dot plot (especially since you are still liable to see latent evidence of pseudoknotted structures without this anyways)
Also fwiw, while we should probably use the globals for the other values for consistency, as mentioned they are identical and we never touch them anyways, so I don't consider that a significant issue
The pfunc call in the GetDotPlot function in FullFold.cpp has teh complexity hardcoded to 3, sodium hardcoded to 1, magnesium hardcoded to 0, and use_long_salt hardcoded to 0. The big issue is complexity 3 being hardcoded as to find pairs for pknots you need to pass complexity as 5 or 8. A complexity of 3 is for non-pknot structures. The pfunc code uses complexity to determine whether to perform pknot routines and a complexity 3 means only run simple non-pknot routines. It is worth noting that we do set the global C variable for sodium, magnesium and long salt, and complexity adn they are the same but the complexity is a big issue
The text was updated successfully, but these errors were encountered: