Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dot plot is not evaluated with pknots when pknots are enabled #670

Open
LunarFawn opened this issue Aug 14, 2022 · 1 comment
Open

Dot plot is not evaluated with pknots when pknots are enabled #670

LunarFawn opened this issue Aug 14, 2022 · 1 comment
Labels
pending triage type: bug Something isn't working

Comments

@LunarFawn
Copy link
Contributor

LunarFawn commented Aug 14, 2022

The pfunc call in the GetDotPlot function in FullFold.cpp has teh complexity hardcoded to 3, sodium hardcoded to 1, magnesium hardcoded to 0, and use_long_salt hardcoded to 0. The big issue is complexity 3 being hardcoded as to find pairs for pknots you need to pass complexity as 5 or 8. A complexity of 3 is for non-pknot structures. The pfunc code uses complexity to determine whether to perform pknot routines and a complexity 3 means only run simple non-pknot routines. It is worth noting that we do set the global C variable for sodium, magnesium and long salt, and complexity adn they are the same but the complexity is a big issue

@LunarFawn LunarFawn changed the title GetDotPlot in FullFold.cpp is hardcoded with numerical values that should have variables which are defined at call GetDotPlot in FullFold.cpp is hardcoded with numerical values that prevent pseudoknots pairs from ever being returns Aug 14, 2022
@LunarFawn LunarFawn changed the title GetDotPlot in FullFold.cpp is hardcoded with numerical values that prevent pseudoknots pairs from ever being returns GetDotPlot in FullFold.cpp is hardcoded with numerical values that prevent pseudoknots pairs from being returned properly Aug 14, 2022
@luxaritas luxaritas added the type: bug Something isn't working label Mar 22, 2023
@luxaritas luxaritas changed the title GetDotPlot in FullFold.cpp is hardcoded with numerical values that prevent pseudoknots pairs from being returned properly Dot plot is not evaluated with pknots when pknots are enabled Mar 22, 2023
@luxaritas
Copy link
Member

While I will mark this as a bug, we have intentionally not fixed this due to the long compute time when enabling pknots for the dot plot (especially since you are still liable to see latent evidence of pseudoknotted structures without this anyways)

Also fwiw, while we should probably use the globals for the other values for consistency, as mentioned they are identical and we never touch them anyways, so I don't consider that a significant issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pending triage type: bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants