Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import paths #3

Open
GregTheGreek opened this issue Jul 5, 2019 · 8 comments
Open

Import paths #3

GregTheGreek opened this issue Jul 5, 2019 · 8 comments

Comments

@GregTheGreek
Copy link
Contributor

We need to update the import paths to reflect etclabscore/go-ethereum and not eth-classic this will also require us to fork over necessary repositories.

@soc1c
Copy link
Contributor

soc1c commented Jul 5, 2019

🤦‍♂️

@steviezhang steviezhang changed the title Import parths Import paths Jul 5, 2019
@soc1c
Copy link
Contributor

soc1c commented Jul 8, 2019

I don't think either of the described tasks is actually necessary because all remotes are public.

@eyfl
Copy link

eyfl commented Aug 7, 2019

I think it's better to update the import paths to etclabscore/go-ethereum to ensure latest code is used.

@soc1c
Copy link
Contributor

soc1c commented Aug 7, 2019

Yup

@austinabell
Copy link
Contributor

I think it's better to update the import paths to etclabscore/go-ethereum to ensure latest code is used.

Just to clear up any possible confusion, no code from eth-classic is used, other than ethash, benchmark and go-ethereum/accounts/abi/bind (the latter I'm about to open a PR to remove that reference) and none of these have changed anytime recently and no plans before the rename to change afaik.

One of those go modules things

@soc1c
Copy link
Contributor

soc1c commented Aug 8, 2019

@austinabell please run grep -i "github\\.com\/eth\-classic" . -R

There are 1067 references to eth-classic

@austinabell
Copy link
Contributor

austinabell commented Aug 8, 2019

@austinabell please run grep -i "github\\.com\/eth\-classic" . -R

There are 1067 references to eth-classic

Not as simple because ethash cross references eth-classic, but instead of cloning the repo like we did before, we would just have to fork it and rename

@soc1c
Copy link
Contributor

soc1c commented Aug 9, 2019

Not getting it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants