Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TableFooter could use <tfoot> ? #73

Open
Glidias opened this issue Feb 22, 2022 · 2 comments
Open

TableFooter could use <tfoot> ? #73

Glidias opened this issue Feb 22, 2022 · 2 comments

Comments

@Glidias
Copy link

Glidias commented Feb 22, 2022

Reproduction:

Run <TableFooter> within <Table>.

Problem description:

index.js:1 Warning: validateDOMNesting(...): <div> cannot appear as a child of <tfoot>.
    at div
    at http://localhost:3000/static/js/vendors~main.chunk.js:4627:21
    at tfoot
    at table
    at div
    at http://localhost:3000/static/js/vendors~main.chunk.js:4340:21
    at div

Suggested solution:

Use <tfoot> element instead of plain div element for TableFooter component.

@narimanb
Copy link

narimanb commented Jul 3, 2023

Changed from <div> to <tfoot>. https://github.com/narimanb/wreactui

@Glidias
Copy link
Author

Glidias commented Sep 21, 2023

Actually, according to the documentation under <TableFooter>, it could be a generic <div> since it can be placed under TableContainer as in the example https://windmillui.com/react-ui/components/table#table-footer

However, it would be good if there was an option to choose tag between "div" | "tfoot" tag as that might come in useful depending on where you're placing it. Besides "div", may even | "footer" for html5 sementic-preference.

@Glidias Glidias changed the title TableFooter should use <tfoot> TableFooter should use <tfoot> ? Sep 21, 2023
@Glidias Glidias changed the title TableFooter should use <tfoot> ? TableFooter could use <tfoot> ? Sep 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants