Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I want tailwind v3 compatibility for windmill react ui. #71

Open
sumgwork opened this issue Dec 11, 2021 · 5 comments
Open

I want tailwind v3 compatibility for windmill react ui. #71

sumgwork opened this issue Dec 11, 2021 · 5 comments

Comments

@sumgwork
Copy link

Is your feature request related to a problem? Please describe.
I would like @windmill/react-ui package to be supported in applications that are using tailwindcss v3 or above.

Describe the solution you'd like
With the current configuration, I see how windmill wrapper for config uses purge and not content. In order to use it with tailwindcss v3, I guess some changes will be required.

Describe alternatives you've considered
Not really at the moment.

Additional context

@ngduc
Copy link

ngduc commented Jan 21, 2022

can't wait to have this great UI kit upgraded with tailwind v3, I forked it here:
https://github.com/ngduc/windmill-react-ui-kit
upgraded and fixed a few things for storybook also.

@jblossomweb
Copy link

I am using Next.js, Tailwind 3, Windmill, and Storybook.
mine borked on what I assume are new color classes that came with Tailwind 3.
Other Tailwind classes worked, so guessing it was the version mismatch.
tried the fork, and it didn't break, but also didn't fix my issue.

this is what worked for me:

const windmill = require('@windmill/react-ui/config')

const config = {
  content: ['./src/app/**/*.{js,ts,jsx,tsx}'],
  theme: {
    extend: {},
  },
  plugins: [],
}

module.exports = {
  ...windmill(config),
  ...config,
}

Basically, I let Windmill's Tailwind 2 config read my Tailwind 3 config without eating it, by using spread operators.
I'm going to roll with it. Figure it's a decent workaround for now, In case it helps anyone 🤷

@dhatGuy
Copy link

dhatGuy commented Jan 3, 2023

I tried the solution above, but some class names are not applied

https://stackblitz.com/edit/vitejs-vite-qtez3g

@henzyd
Copy link

henzyd commented Apr 10, 2023

@jblossomweb I tried your solution and it worked, thank you.

@narimanb
Copy link

narimanb commented Jul 3, 2023

Is your feature request related to a problem? Please describe. I would like @windmill/react-ui package to be supported in applications that are using tailwindcss v3 or above.

Describe the solution you'd like With the current configuration, I see how windmill wrapper for config uses purge and not content. In order to use it with tailwindcss v3, I guess some changes will be required.

Describe alternatives you've considered Not really at the moment.

Additional context

Tailwind V3
https://github.com/narimanb/wreactui

  • renamed the 'purge' to 'content'
  • removed 'variants' configuration
  • updated new tailwind syntax for 'opacity'
  • storybook v7, react testing library, tailwindcss V3, tailwindcss/forms 0.5.3
    ...,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants