Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transition component doesn't work properly on entrance #25

Open
muametgrooby opened this issue Dec 8, 2020 · 2 comments
Open

Transition component doesn't work properly on entrance #25

muametgrooby opened this issue Dec 8, 2020 · 2 comments

Comments

@muametgrooby
Copy link

  • windmill-react-ui version: 0.5.0

What you did:

I updated the windmill-ui package on windmill-dashboard-react.

What happened:

Components are not being animated on entrance.

Problem description:

It looks like modal and sidebar entrance is not animated as they should be, there's also no transition on the docs when you open the modal:

https://windmillui.com/react-ui/components/modal

Suggested solution:

Looks like downgrading back to 0.3.1 solves the issue.

@graham768
Copy link

I tried to downgrade to 0.4.1 in order to use Alert, but the bug is present in that version too

Downgrading to 0.3.1 solved the problem like @muametgrooby mentioned and I created the alert component manually for the time being.

@Glidias
Copy link

Glidias commented Apr 6, 2022

A workaround is to add a non-empty string on the appear attribute. <Transition show={isOpen} appear="_">

Not sure what's the issue could be typescript-related. But doing the above workaround allows enter transition to work. It seems

Warning: Failed prop type: Invalid prop `appear` of type `string` supplied to `Transition`, expected `boolean`.

for the CSSTransition library. I think their documentation is faulty.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants