Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

find replacement for buf_redux library #1835

Open
marcmo opened this issue Jun 19, 2023 · 4 comments
Open

find replacement for buf_redux library #1835

marcmo opened this issue Jun 19, 2023 · 4 comments
Assignees
Labels
native implemented in the rust part (natively) rust Pull requests that update Rust code

Comments

@marcmo
Copy link
Member

marcmo commented Jun 19, 2023

library is not supported anymore

@marcmo marcmo added native implemented in the rust part (natively) rust Pull requests that update Rust code labels Jun 19, 2023
@marcmo marcmo self-assigned this Jun 19, 2023
@AmmarAbouZor
Copy link
Collaborator

I think one of the best candidates is the crate bytes
I'll make some research about it and try to replace it while exploring the source code

@AmmarAbouZor
Copy link
Collaborator

I don't think we can use the crate bytes to replace buf_redux because it doesn't support handling reading from a file directly but rather it works with in-memory bytes only.

I've found the maintained fork buffer_redux, which still hasn't commited changes on the original code besides updating the dependencies, adding CI Pipelines and applying cargo clippy fixes.

I would suggest trying this crate in a draft PR where we can test it and then we can merge if everything is still working fine. We will need to to merge buffer_redux change in Dmitry's fork as well.

@DmitryAstafyev
Copy link
Collaborator

@AmmarAbouZor last time we discussed with @marcmo the possibility to maintain buf_redux crate as well. It isn't a huge lib and already includes some of our changes.
@marcmo it looks like it make sense to make a fork of buf_redux in esrlabs and re-register it also on crates.io. What do you think?

@AmmarAbouZor
Copy link
Collaborator

It would be very interesting to maintain the crate, since it's really low level and has its share of low level implementation across different operating systems and unsafe code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
native implemented in the rust part (natively) rust Pull requests that update Rust code
Projects
None yet
Development

No branches or pull requests

3 participants