Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MobaPlayer class rework #91

Open
8 tasks done
sturdy-robot opened this issue Jan 24, 2023 · 0 comments
Open
8 tasks done

MobaPlayer class rework #91

sturdy-robot opened this issue Jan 24, 2023 · 0 comments
Assignees

Comments

@sturdy-robot
Copy link
Collaborator

sturdy-robot commented Jan 24, 2023

The MobaPlayer class has too many attributes. It should be a simple dataclass.

  • Convert MobaPlayer and Player to dataclasses
  • Add other classes that use MobaPlayer as a component, such as MobaPlayerStats and MobaPlayerSimulation to divide responsibilities
  • Add a serialize() method to return a dictionary of the player (Probably derive from a common Serializable interface). This makes it easier to write this to a database.
  • Make all fields accept the same types:
    • UUID for ID
    • date for date of birth
  • Add get_from_dict() method to make it easier to deserialize data from a dictionary. It makes it easier to load from a database.
  • Remove Skill implementation, to use a different approach
@sturdy-robot sturdy-robot self-assigned this Jan 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant