Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TeamGenerator rework #89

Open
4 tasks
sturdy-robot opened this issue Jan 24, 2023 · 0 comments
Open
4 tasks

TeamGenerator rework #89

sturdy-robot opened this issue Jan 24, 2023 · 0 comments
Assignees

Comments

@sturdy-robot
Copy link
Collaborator

TeamGenerator needs a complete overhaul. All the Generators need to comply to a common interface: IGenerator.

The TeamGenerator should not store lists of teams, and should not store Objects and Dicts.

  • Remove self.teams_obj and self.teams_dict
  • Generate functions should return the list of generated teams
  • Generator class should not get teams from the database
  • We might use a teams_def file to get team definitions from a common place. This would allow more previsibility to get teams, and we could divide teams by region.
@sturdy-robot sturdy-robot self-assigned this Jan 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant