New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PlayerGenerator rework #88

Open

3 tasks done

sturdy-robot opened this issue Jan 24, 2023 · 0 comments

Assignees

Collaborator

sturdy-robot commented Jan 24, 2023 •

edited

PlayerGenerator needs a complete overhaul. All the Generators need to comply to a common interface: IGenerator.

The PlayerGenerator should not store lists of champions, and should not store Objects and Dicts.

Remove self.players_obj and self.players_dict
Generate functions should return the list of generated players
Generator class should not get players from the database

sturdy-robot self-assigned this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment