Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor champion, player and team lists #82

Open
sturdy-robot opened this issue May 17, 2022 · 0 comments
Open

Refactor champion, player and team lists #82

sturdy-robot opened this issue May 17, 2022 · 0 comments
Assignees
Labels
refactor Needs a refactor work

Comments

@sturdy-robot
Copy link
Collaborator

The lists of objects nowadays require iterating over the list to look for champions, players and teams. I guess a better way to implement this is to use a dictionary as a lookup table:

{
"TEAM1_ID": {team1_data}
"TEAM2_ID": {team2_data}
}

@sturdy-robot sturdy-robot created this issue from a note in eSports Manager 0.1.0-alpha (To do) May 17, 2022
@sturdy-robot sturdy-robot added the refactor Needs a refactor work label May 17, 2022
@sturdy-robot sturdy-robot self-assigned this Jan 27, 2023
@sturdy-robot sturdy-robot moved this from To do to In progress in eSports Manager 0.1.0-alpha Mar 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor Needs a refactor work
Projects
Development

No branches or pull requests

1 participant