padding-line-between-statements: support arrow node type

[Jelmerro]

Clear and concise description of the problem

I would like the arrow node type to be added to the list of node types for the padding-line-between-statements rule. Currently const funcname = () => {...} is interpreted as const, which is technically true, but is also a very common way to define functions without the function keyword. As such, it would help for controlling padding lines to be able to select lines with arrow functions in them.

Suggested solution

diff --git a/packages/eslint-plugin-js/rules/padding-line-between-statements/padding-line-between-statements.ts b/packages/eslint-plugin-js/rules/padding-line-between-statements/padding-line-between-statements.ts
index 449a9c4..74c441a 100644
--- a/packages/eslint-plugin-js/rules/padding-line-between-statements/padding-line-between-statements.ts
+++ b/packages/eslint-plugin-js/rules/padding-line-between-statements/padding-line-between-statements.ts
@@ -91,6 +91,24 @@ function isIIFEStatement(node: ASTNode): boolean {
   return false
 }
 
+/**
+ * Checks whether the given node is an arrow function.
+ * @param node The node to check.
+ * @returns `true` if the node is a arrow-function statement.
+ * @private
+ */
+function isArrowFuntion(node: ASTNode): boolean {
+  if (
+      node !== null &&
+      node.type === "VariableDeclaration" &&
+      node.declarations[0].init !== null &&
+      node.declarations[0].init.type === "ArrowFunctionExpression"
+  ) {
+      return true;
+  }
+  return false;
+}
+
 /**
  * Checks whether the given node is a block-like statement.
  * This checks the last token of the node is the closing brace of a block.
@@ -293,6 +311,9 @@ const PaddingTypes = {
  */
 const StatementTypes = {
   '*': { test: () => true },
+  'arrow': {
+    test: (node) => isArrowFuntion(node),
+  },
   'block-like': {
     test: (node, sourceCode) => isBlockLikeStatement(sourceCode, node),
   },

Alternative

No response

Additional context

The feature is taken from here: https://github.com/eslint/eslint/pull/16970/files and was rejected by eslint as being too stylistic, hence I would like to have it added to stylistic.

Validations

• Follow our Code of Conduct
• Read the Contributing Guide.
• Check that there isn't already an issue that request the same feature to avoid creating a duplicate.

Contributes

• If this feature request is accepted, I am willing to submit a PR to fix this issue