jsx-one-expression-per-line: ignoreComments

[otomad]

Clear and concise description of the problem

Adding a comment at the end of a jsx line can unexpectedly raise jsx-one-expression-per-line. Although I don't assume comment in jsx as a common expression.

For example:

<Foo>bar</Foo>{/* TODO: This line may be deleted. */}

However, the comment {/* */} will be treat as a common expression {}.

Suggested solution

Add a ignoreComments option to the jsx-one-expression-per-line rule.

"@stylistic/jsx/jsx-one-expression-per-line": [<enabled>, { "allow": "none"|"literal"|"single-child", "ignoreComments": boolean }]

Alternative

Or add a new rule jsx-lines-around-comment which similar to lines-around-comment but in JSX, and also ignore comments in jsx-one-expression-per-line.

Additional context

Although maybe it is better to write as

{/* TODO: The next line may be deleted. */}
<Foo>bar</Foo>

I am more accustomed to add a comment after lines in JavaScript.

const foo = "bar"; // TODO: Something todo.

Validations

• Follow our Code of Conduct
• Read the Contributing Guide.
• Check that there isn't already an issue that request the same feature to avoid creating a duplicate.

Contributes

• If this feature request is accepted, I am willing to submit a PR to fix this issue

[01taylop]

The rule from eslint-plugin-react added a non-jsx option "to allow non-JSX children in one line". I wonder if that change would resolve this issue too?