Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(detect-child-process): false positives for destructuring spawn #103

Merged
merged 1 commit into from
Dec 14, 2022

Conversation

ota-meshi
Copy link
Member

@ota-meshi ota-meshi commented Dec 8, 2022

This PR fixes false positives in detect-child-process.

With this change, calls to require("child_process") will no longer be reported if destructuring assignment is used.

fixes #51

Copy link
Contributor

@nzakas nzakas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks.

@nzakas nzakas merged commit fdfe37d into main Dec 14, 2022
@nzakas nzakas deleted the issue51 branch December 14, 2022 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

detect-child-process false-positive with spawn
2 participants