Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider adding optional Query to notification hook config, that must match the document in order for a notification to be written #27

Open
alechenninger opened this issue Oct 18, 2016 · 0 comments

Comments

@alechenninger
Copy link
Contributor

This encodes more business logic in the notification hook, which complicates our deployment since it means notification processing is further coupled to deployed metadata, however it can be a good performance improvement in some cases.

A tradeoff between complexity and performance.

That being said, there is another way to improve performance in all cases that does not add as much complexity. See: esbtools/event-handler#70

Impl note: the query could be evaluated simply against the post document provided to the hook. If it matches the document, then we will write the notification. Consider which is faster: evaluating the query first or evaluating the watch projection first.

/cc @paterczm since we were talking about this a bit today.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant