Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rest save client is very not thread safe #174

Open
alechenninger opened this issue May 26, 2016 · 0 comments
Open

Rest save client is very not thread safe #174

alechenninger opened this issue May 26, 2016 · 0 comments
Labels

Comments

@alechenninger
Copy link
Contributor

alechenninger commented May 26, 2016

It accepts a apache http client, but closes it after every call. This means multiple threads cannot safely share the same rest client instance.

I'm not sure what is relying on this behavior, and so if we fix it directly it may introduce resource leaks for clients that aren't closing their http client elsewhere.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant