Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce overall size of EsbMessageAdminServiceImpl class. #143

Open
derek63 opened this issue Sep 3, 2015 · 1 comment
Open

Reduce overall size of EsbMessageAdminServiceImpl class. #143

derek63 opened this issue Sep 3, 2015 · 1 comment

Comments

@derek63
Copy link
Member

derek63 commented Sep 3, 2015

I made it too big with #142, so let's reevaluate what is in here and move things around accordingly

@derek63 derek63 added this to the Phase 3 milestone Sep 3, 2015
@derek63 derek63 added the ready label Sep 3, 2015
@alechenninger
Copy link
Contributor

I like the approach of starting big then pulling out what needs to, versus starting with too many tiny pieces. What thing I thought while looking through the refactor was maybe the metadata keys stuff could be it's own thing. I say this because it would remove some of the need for the KeyExtractorUtil to be instantiated and cached there. You could inject it instead. You couldn't do that now because it requires metadata, so it would have a circular dependency. But, if metadata was it's own thing, it would only depend on that, and the ema service would then depend on both.

Just a thought at a glance, I'm still new to the Java side of EMA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants