Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is swerv_eh1 core deprecated? #29

Open
jrmejiaa opened this issue May 6, 2023 · 5 comments
Open

Is swerv_eh1 core deprecated? #29

jrmejiaa opened this issue May 6, 2023 · 5 comments
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@jrmejiaa
Copy link

jrmejiaa commented May 6, 2023

Hi all,

The rule swerv_setup is no longer working with the core Cores-VeeR-EH1 (previous SweRV). I saw that there is a fork of this core with the rule swerv_eh2_setup. This means that the rule and work of swerv_setup and swerv_pe is deprecated?

Thank you,

JM

@cahz
Copy link
Member

cahz commented May 6, 2023

SweRV EH1 support in tapasco-riscv is not deprecated. Please don't mix it up with the EH2, which is a different core. (Both have in common that the name was changed recently)

Even after the name change, the old locations should still work. What exactly is your issue with the SweRV?

@jrmejiaa
Copy link
Author

jrmejiaa commented May 8, 2023

The setup is not working as expected because of a mismatch in the patch. Maybe it is better to go to an specific commit and not to the master branch?

make swerv_setup
riscv/swerv/setup.sh
Cloning into 'swerv_eh1'...
remote: Enumerating objects: 1056, done.
remote: Counting objects: 100% (212/212), done.
remote: Compressing objects: 100% (45/45), done.
remote: Total 1056 (delta 174), reused 167 (delta 167), pack-reused 844
Receiving objects: 100% (1056/1056), 18.03 MiB | 12.56 MiB/s, done.
Resolving deltas: 100% (653/653), done.
../swerv_tapasco.patch:438: trailing whitespace.
// 
../swerv_tapasco.patch:440: trailing whitespace.
// 
../swerv_tapasco.patch:444: trailing whitespace.
// 
../swerv_tapasco.patch:446: trailing whitespace.
// 
error: design/include/swerv_types.sv: No such file or directory
error: design/swerv.sv: No such file or directory
error: design/swerv_wrapper.sv: No such file or directory
riscv/swerv/setup.sh: line 10: ./swerv.config: No such file or directory

@c-93
Copy link
Contributor

c-93 commented May 8, 2023

Without reproducing your problem (yet): Your finding seems correct. One could either check-out an older version of eh1, or adapt the patch for eh1.

@cahz
Copy link
Member

cahz commented May 8, 2023

Ah ok. They not just renamed the core but also the file names. Feel free to update the patch.

@cahz cahz added good first issue Good for newcomers help wanted Extra attention is needed labels May 8, 2023
@jrmejiaa
Copy link
Author

Hi, I cannot create a new fork just for this change, so I prefer not to make my own PR, but if you apply this patch, the core would work as expected with the last version of the master branch.

# From taspasco-riscv root folder
git apply fix_swerv.patch

Please let me know if this works also for you.

fix_swerv.zip

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants