Skip to content
This repository has been archived by the owner on Nov 9, 2018. It is now read-only.

usb-canary will exit due to errors #17

Open
1 of 2 tasks
jaseg opened this issue Oct 8, 2017 · 2 comments
Open
1 of 2 tasks

usb-canary will exit due to errors #17

jaseg opened this issue Oct 8, 2017 · 2 comments
Assignees
Labels
bug enhancement in progress A feature request or bug that is currently being worked on

Comments

@jaseg
Copy link

jaseg commented Oct 8, 2017

In several places, usb-canary will quietly exit depending on external conditions. One such place is the twilio message handler. If a mere network error occurs, it will quietly exit.

  • Feature Request
  • Bug Report

Expected Behavior

When a messaging channel is configured and errors occur, usb-canary should asynchronously retry as many times as necessary to send the message. Under no conditions should failure of one messaging channel prevent other intact channels from working.

Current Behavior

If e.g. twilio and slack are enabled, and the twilio code raises an error, usb-canary will exit without even attempting to use slack.

Possible Solution

Handle all messaging asynchronously with appropriate back-off.

Steps to Reproduce (for bugs)

Context

usb-canary at least on first glance looks like a security tool. Thus it should be secure.

Your Environment

This is independent of operating system.

@errbufferoverfl
Copy link
Owner

Hi @jaseg,

Thanks for submitting an issue, this has been put into the roadmap. Again thanks for taking the time to contribute to USB Canary.

@errbufferoverfl
Copy link
Owner

Along with other improvements referenced in other issue comments, I am currently working on better error handling where possible, a number of improvements have been made, including using a different daemon which will allow - in case of failure of other logging mechanisms - logging to at least be done.

@errbufferoverfl errbufferoverfl added the in progress A feature request or bug that is currently being worked on label May 7, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug enhancement in progress A feature request or bug that is currently being worked on
Projects
Development

No branches or pull requests

2 participants