Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

suggestion: Name predicate instructions to indicate boolean return value #52

Open
Vaguery opened this issue Mar 17, 2017 · 1 comment
Open

Comments

@Vaguery
Copy link
Contributor

Vaguery commented Mar 17, 2017

I am noticing instructions like _exec_empty cropping up quite a lot. I realize that in Python variable names can only include underscores and Alnum characters, but I wonder if it might make Push code a bit more readable to name these in the Mathematica style: ending in Q (indicating "question", I guess?).

So for example _exec_empty_Q.

Just a minor suggestion. In Clojure implementations I use exec-empty?, and it helps readability quite a bit.

@erp12
Copy link
Owner

erp12 commented Mar 17, 2017

I like this idea. It will help distinguish between instruction like _exec_emtpy and _exec_flush. To someone who doesn't have a full knowledge of the instruction set, those might appear to do the same thing with the current naming.

@erp12 erp12 added this to the Beta 0.1 milestone Jul 28, 2017
@erp12 erp12 removed this from the Beta 0.1 milestone Feb 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants