Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify the Evaluator and Estimator APIs #150

Open
erp12 opened this issue Jul 22, 2020 · 2 comments
Open

Modify the Evaluator and Estimator APIs #150

erp12 opened this issue Jul 22, 2020 · 2 comments
Milestone

Comments

@erp12
Copy link
Owner

erp12 commented Jul 22, 2020

Evaluators should support custom loss functions to compare the actual and expected outputs of program.

The .fit() method of the estimator should support either:

  • .fit(X, y, loss_fn) where loss_fn is a custom loss function.
  • .fit(evaluator) where evaluator is an instance of an evaluator to use in place of a dataset.
@erp12 erp12 added this to the 1.0 milestone Jul 22, 2020
@nbro
Copy link
Contributor

nbro commented Dec 14, 2020

@erp12 This indeed seems to be a big limitation of the library/API.

Are you planning to work on this?

The last commit was 4 months ago, it seems that you're not planning to work on this and the other issues any time soon.

@erp12
Copy link
Owner Author

erp12 commented Dec 14, 2020

This project is not abandoned :)

I dedicate some of my free time to the development of PyshGP (and other projects) and I am currently the only contributor. We all have to choose how to best spend our time, and it isn't every day that this library reaches the top of my priorities.

That said, contributions are always welcome. If you would like to work on a pull request for this, I would be happy to assist you. I can provide more details on what parts of the codebase would need to change, if you are interested.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants