Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No lambda, gamma for XGBoostRegressionTree? #97

Open
jinwoolim8180 opened this issue Sep 26, 2021 · 0 comments
Open

No lambda, gamma for XGBoostRegressionTree? #97

jinwoolim8180 opened this issue Sep 26, 2021 · 0 comments

Comments

@jinwoolim8180
Copy link

I am new to XGBoost and I was trying to study it through your code.
I found that lambda and gamma(min_split_loss) were missing and these values should be considered in function _gain_by_taylor and _approximate_update.
Also I think some of the important features such as pruning are missing in your code... Didn't look at the code thoroughly so I could be wrong

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant