Feature Request - Support TLS

[gwharton]

Please support tls connections for redis servers.

AWS Elasticache redis instances with AUTH enabled now only support tls connections.

[erikdubbelboer]

In theory this is already possible. I don't have a setup to test. But I think you can set host to something like tls://hostname?ssl[verify_peer]=0 or tls://hostname?ssl[cafile]=private.pem&ssl[verify_peer]=1. Can you check if that works?

[gwharton]

Ahh yes, it should work, but looking at the code, only if you do not set the port variable.

phpRedisAdmin/includes/common.inc.php

Lines 116 to 121 in bf71b74

	// Setup a connection to Redis.
	if(isset($server['scheme']) && $server['scheme'] === 'unix' && $server['path']) {
	$redis = new Predis\Client(array('scheme' => 'unix', 'path' => $server['path']));
	} else {
	$redis = !$server['port'] ? new Predis\Client($server['host']) : new Predis\Client('tcp://'.$server['host'].':'.$server['port']);
	}

[gwharton]

I tried not setting the port variable to see if I could use a full connection string, and alas the following code automatically sets the port setting if it doesn't exist.

phpRedisAdmin/includes/config.environment.inc.php

Lines 45 to 54 in bf71b74

	if (empty($server_port)) {
	$server_port = 6379;
	}
	$config['servers'][] = array(
	'name' => $server_name,
	'host' => $server_host,
	'port' => $server_port,
	'filter' => '*',
	);

I'm guessing this only becomes an issue when setting the servers from environment variables, i.e in docker. I haven't been able to try this when setting the servers from config.inc.php which I suspect will work if you don't declare a port.

[gwharton]

OK, ive tried it using the config file instead of environment variables.

      array(
          'name'   => 'master.xxxx.xxxx.euw2.cache.amazonaws.com',
          'host'   => 'tls://master.xxxx.xxxx.euw2.cache.amazonaws.com:6379',
          'port'   => '',
          'filter' => '*',
          'scheme' => 'tcp',
          'path'   => '',
          'hide'   => false,
          'auth' => 'xxxx'
      )

This works and seems to connect to the redis server.

[erikdubbelboer]

Great, I'll keep this task open for if one day I have time to improve support and fix that port logic.