You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
While testing @cpplearner's implementation of C++23 P2770R0 "Stashing stashing iterators for proper flattening" in microsoft/STL#3466 , we found that this breaks a range-v3 test. These lines now emit errors:
Hey @StephanTLavavej, thanks for the issue! If simply checking that the range is input-only rather than forward is sufficient (and the actual test that checks the content passes), then that's probably the right fix.
After all, these were always input-only to begin with - just misnamed.
No feature test macro for that paper, so I guess the test needs to just check that the resulting iterator matches regex's category.
While testing @cpplearner's implementation of C++23 P2770R0 "Stashing stashing iterators for proper flattening" in microsoft/STL#3466 , we found that this breaks a range-v3 test. These lines now emit errors:
range-v3/test/view/tokenize.cpp
Line 25 in 21b70be
range-v3/test/view/tokenize.cpp
Line 30 in 21b70be
I believe that this is because P2770R0 marks
regex_iterator
andregex_token_iterator
withusing iterator_concept = input_iterator_tag;
.I'm working around this breaking change by updating these lines to check for only
input_range
, but perhaps there's a better solution.The text was updated successfully, but these errors were encountered: