Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Color coding stopped working #32

Open
mcamou opened this issue Oct 15, 2018 · 2 comments
Open

Color coding stopped working #32

mcamou opened this issue Oct 15, 2018 · 2 comments

Comments

@mcamou
Copy link

mcamou commented Oct 15, 2018

Starting sometime last week (or it could have been the previous one) the color coding is not working. All PRs stay green regardless of their status. Currently running on 1.7.1.

@erichbehrens
Copy link
Owner

Thanks for reporting the issue. Could you please provide some example data so I can check why the extension is seeing those PRs as mergeable?

This is the query executed by the extension (except I removed references to repos and PR titles, so it's safe to post the result here). You can execute it from GitHub's GraphQL explorer: https://developer.github.com/v4/explorer/

query {
  viewer {
      pullRequests(last: 10 states:[OPEN]) {
          nodes {
            number
            mergeable
            state
            merged
            potentialMergeCommit {
              status {
                state
              }
            }
            commits(last: 1){
              nodes{
                commit{
                  status{
                    state
                  }
                }
              }
            }
            reviews(first: 10) {
              edges {
                node {
                  state
                }
              }
            }
          }
    }
  }
}

@mcamou
Copy link
Author

mcamou commented Oct 26, 2018

Sorry for taking so long to reply. I've been trying to get authorization from my company to use the GraphQL explorer but haven't been able to. In the end I figured out how to do it with HTTPie. I don't currently have a PR where CI is failing, but this one cannot be merged because it doesn't have any approvals yet. Weirdly enough, GitHub says it's MERGEABLE...

{
    "data": {
        "viewer": {
            "pullRequests": {
                "nodes": [
                    {
                        "commits": {
                            "nodes": [
                                {
                                    "commit": {
                                        "status": null
                                    }
                                }
                            ]
                        },
                        "mergeable": "MERGEABLE",
                        "merged": false,
                        "number": 126,
                        "potentialMergeCommit": {
                            "status": null
                        },
                        "reviews": {
                            "edges": []
                        },
                        "state": "OPEN"
                    }
                ]
            }
        }
    }
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants