Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[windows] wstunnel force close stdio #229

Closed
AnorBanantje opened this issue Feb 14, 2024 · 5 comments
Closed

[windows] wstunnel force close stdio #229

AnorBanantje opened this issue Feb 14, 2024 · 5 comments

Comments

@AnorBanantje
Copy link

Describe the bug
When connection is not successfully started / ended or something wrong in command but command is valid to start process is not possible to kill wstunnel with CTRL +C / CTRL + Z?
Only cmd, powershell window close help here.

To Reproduce
Start powershell or CMD execute:
ssh -o ProxyCommand=".\wstunnel.exe client -L stdio://%h:%p https://127.0.0.1" user@127.0.0.2
Try kill process with CTRL +C or CTRL + Z

Expected behavior
when wstunnel is working CTRL+C or CTRL+Z most close wstunnel and application which uses it.

@erebe
Copy link
Owner

erebe commented Feb 16, 2024

Indeed, I manage to reproduce on Windows.
Regarding how to fix it, for now I don't know, as it seems particular to how windows handle the raw mode of the terminal. It seems all control command/key are swallowed

@erebe erebe changed the title Windows wstunnel force close Windows wstunnel force close stdio Feb 16, 2024
@erebe erebe changed the title Windows wstunnel force close stdio [windows] wstunnel force close stdio Feb 16, 2024
@Maxime-JULLIEN
Copy link

Hi all,

I am encountering the same issue as described above. However, in my case, it's particularly blocking in Datagrip, which uses this connection. Datagrip fails to close an existing connection properly, forcing me to terminate all processes manually to restart them. This is significantly impacting my workflow.

Could we prioritize a fix for this ?

@erebe
Copy link
Owner

erebe commented May 14, 2024

Hello,
Will try to take another look at it in the coming days

@erebe
Copy link
Owner

erebe commented May 18, 2024

hi back,

Would you mind trying this pre-release and let me know https://github.com/erebe/wstunnel/releases/tag/v9.5.0 ?
CTRL+C should be handled, if you hit twice ctrl+c it should exit normally.

@erebe
Copy link
Owner

erebe commented May 19, 2024

I released the v9.5.0 with the changes.
Feel free to re-open if needed

@erebe erebe closed this as completed May 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants