Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

onlyPayloadSize should not be necessary with Solidity 0.5 #277

Open
fulldecent opened this issue Nov 18, 2019 · 1 comment
Open

onlyPayloadSize should not be necessary with Solidity 0.5 #277

fulldecent opened this issue Nov 18, 2019 · 1 comment

Comments

@fulldecent
Copy link
Contributor

I learned the hard way that Solidity has stronger type safety. Because it broke the ERC-165 reference implementation. The function onlyPayloadSize seems to be testing for something that Solidity now automatically tests for.

Recommendation: review if onlyPayloadSize is necessary.

References:

@thegostep
Copy link
Contributor

Mock NMR should really be compiled with solc 0.4.11 in order to match the deployed token https://etherscan.io/address/0x1776e1f26f98b1a5df9cd347953a26dd3cb46671#code

Future improvement will be to modify compilation script to support multiple solidity versions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants